Add browser events and describe their payload #838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
reviewed
Apr 9, 2024
lmolkova
reviewed
Apr 9, 2024
bripkens
reviewed
Apr 14, 2024
bripkens
reviewed
Apr 14, 2024
bripkens
reviewed
Apr 14, 2024
Also, removing exception event; will be adding it as separate generic event.
bripkens
reviewed
Apr 23, 2024
bripkens
reviewed
Apr 23, 2024
bripkens
reviewed
Apr 23, 2024
This was referenced Apr 23, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
as it's moved to a separate PR
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
@open-telemetry/specs-semconv-approvers can someone please re-open this PR? thanks. |
|
@scheler please resolve conflicts for this one, thank you |
as discussed in Event SIG on 7/26, since it is added after the event is emitted by the instrumentation. Keeping session.id since it's well agreed upon.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add browser events and describe their payload
Changes
This PR adds the semantic conventions for browser events describing their name and payload. This is based on the recently agreed upon convention that payload will go in LogRecord's body field, and that the payload fields in the body do not need to be part of global registry and therefore do not need to have a namespace.
NOTE: not adding the yaml version since that's not ready yet from the build-tools perspective.
Merge requirement checklist
[chore]